Move ptable logic from tl_content to DC_Table #6645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like we should have an access voter before we can make this improvement? 🤔 |
Why? |
Should be fixed in e7002e1 |
leofeyer
approved these changes
Dec 21, 2023
|
Thank you @ausi. |
leofeyer
added a commit
that referenced
this pull request
Feb 2, 2024
…method (see #6833) Description ----------- Fixes #6824 Now that we have merged #6645, we can revert these changes. Commits ------- ea67382 Revert the changes to the `Controller::getParentEntries()` method ef335ed Also check the ptable in the SQL query 7db085f Fix getParentEntries() (see #10) Co-authored-by: ausi <martin@auswoeger.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need to check for
Input::get('ptable')in the tl_content DCA. Not sure if this is the right approach though.