Add an image size voter #6646
Add an image size voter #6646
Conversation
Probably not. 🙈 But @ausi might know. |
|
AFAIK we only have permissions per image size for being accessible in the widget dropdown. If a user has access to the image sizes admin view is not related to that. For the admin view we do not have specific permissions per image size. I think this is correct and the image-sizes-widget-dropdown-permission should not get mixed with the general CRUD-permissions for tl_image_sizes.
This feature is from @qzminski and @aschempp see contao/core-bundle#319 so they should know the intention best |
|
yeah, I was just confused by the fact that a user might not have access to an image size in the widget, but can edit it. So a user can not see an option in the list, but can duplicated said option and then have access to the new one. Not sure that's really intended? For example with forms, the user permission to limit the forms affects both the list in the back end as well as the widget in the form element dropdown. |
It is not. We should fix this IMHO. |
I thought so, too. However, there is currently no permission to add or delete an image size, like there ususally is for e.g. news archives. Which means if a user is given access to the image size theme module, they should be able to do anything to that (CRUD). Which ultimately means they should have all image sizes… 🤔 |
leofeyer
added
the
up for discussion
aschempp
removed
the
up for discussion
|
I have created a new issue (#6693) for the open question. This PR should be RTM and implements the current behaviour. |
|
Thank you @aschempp. |
@contao/developers what I find confusing is that a user can have access to only a limited number of image sizes, but they can still see all images sizes. They can also edit all images sizes. But only if they add a new image size, it is added to their user permission to make it accessible in the widget dropdown. Is that something we intentionally do?