Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort options by key if they use language references #6652

Merged
merged 1 commit into from Jan 2, 2024

Conversation

leofeyer
Copy link
Member

@leofeyer leofeyer commented Dec 22, 2023

Before


After

@leofeyer leofeyer added this to the 5.3 milestone Dec 22, 2023
@leofeyer leofeyer self-assigned this Dec 22, 2023
@leofeyer leofeyer requested a review from a team December 22, 2023 14:01
@leofeyer leofeyer merged commit 839d1ff into contao:5.x Jan 2, 2024
17 checks passed
@leofeyer leofeyer deleted the feature/sort-elements branch January 2, 2024 17:03
leofeyer added a commit that referenced this pull request Feb 1, 2024
Description
-----------

Reverts #6652 because that caused **every dropdown widget** from being alphabetically sorted, even if a developer had a custom sorting. It also now has a more consistent sorting of elements as people are used to.

Commits
-------

3c58dd2 Fix order of content elements
1d742b2 Fix the unit tests

Co-authored-by: leofeyer <1192057+leofeyer@users.noreply.github.com>
leofeyer added a commit to contao/core-bundle that referenced this pull request Feb 1, 2024
Description
-----------

Reverts contao/contao#6652 because that caused **every dropdown widget** from being alphabetically sorted, even if a developer had a custom sorting. It also now has a more consistent sorting of elements as people are used to.

Commits
-------

3c58dd21 Fix order of content elements
1d742b2e Fix the unit tests

Co-authored-by: leofeyer <1192057+leofeyer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant