Only check the first record to be restored #6665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toflar
reviewed
Dec 27, 2023
|
added in afc89fb |
Toflar
previously approved these changes
Dec 27, 2023
leofeyer
previously approved these changes
Dec 27, 2023
leofeyer
changed the title
|
Thank you @aschempp. |
leofeyer
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a bug in my PR #6642
The undo table will contain data of a record and all its child records. However, we cannot check permissions on all child records, they will most likely fail because their parent is not present. We can only check the actualy record and have to assume its children can be added as well.
The actual
DC_Table::undo()will check each record to be restored, but the operation callback cannot do that upfront.