New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more database indexes #6683
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not add the index tl_content.ptable
and tl_page.dns,fallback,published,start,stop
, see code comments.
The rest LGTM 🚀
Co-authored-by: Martin Auswöger <martin@auswoeger.com>
Co-authored-by: Martin Auswöger <martin@auswoeger.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, apart from #6683 (comment)
Thank you @Toflar. |
Fixes #6681
@contao/developers I've only added indexes to the columns that were part of my slow query log. Of course, that will probably be different in other setups. An alternative would be to automate adding the indexes for columns such as
relation
of'type'=>'hasOne'
or'type'=>'belongsTo'
Not sure if we'd end up having too many indexes?