Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the description of the "template data" field #6689

Merged
merged 1 commit into from Jan 5, 2024

Conversation

fiedsch
Copy link
Contributor

@fiedsch fiedsch commented Jan 5, 2024

Fixes #6685 as explained here.

To my understanding, the fix in the *.xlf files would be done on transifex. I applied for access there and was asked for my language(s). As far as I understand transfix I would need to be member of each langauge's team in order to submit a translation.

In this special case however I think one could fix all languages without even speaking or reading the language.

You could tell that

<target>これらの値は&lt;code&gt;$this-&gt;data&lt;/code&gt;としてテンプレートで利用できます。</target>

would become

<target>これらの値は&lt;code&gt;$this-&gt;keys&lt;/code&gt;としてテンプレートで利用できます。</target>

without understanding これらの値は etc.

Is there an easy way that I am missing; how to proceed from here?

@leofeyer leofeyer linked an issue Jan 5, 2024 that may be closed by this pull request
@leofeyer leofeyer changed the title Fix issue #6685 Fix the description of the "template data" field Jan 5, 2024
@leofeyer leofeyer merged commit 5920229 into contao:4.13 Jan 5, 2024
17 of 18 checks passed
@leofeyer
Copy link
Member

leofeyer commented Jan 5, 2024

Thank you @fiedsch.

@leofeyer
Copy link
Member

leofeyer commented Jan 5, 2024

how to proceed from here?

You are done. 😄 The source strings will be pushed to Transifex at some point and then the translators are notified about the change and they will adjust their translations accordingly.

@fiedsch fiedsch deleted the fix_translation branch January 5, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Description of "Template Data" in "Custom Template" content element
2 participants