Allow insert tags in link titles #6720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofeyer
approved these changes
Jan 17, 2024
|
yes, what I meant was I'm not sure if it should be allowed in the title as well, and how that would be done in Twig. But this sure is correct anyway. |
m-vo
approved these changes
Jan 21, 2024
leofeyer
changed the title
|
Thank you @aschempp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often use
{{link_url::42}}for the page link, and then use{{link_title::42}}for the link title. That does not seem to work anymore with the Twig templates.Not sure if that should also work on the link title (the HTML attribute) and how that would be accomplished in
attrs...