Add a Twig function to generate content URLs

[aschempp]

First thing I found missing while using content URLs in my project 🙃

[Toflar]

This needs a try catch block 🤔

[bytehead]

Apart from failing CS 👍

[m-vo]

Any reason this is a separate extension and not in our default ContaoExtension like the other stuff?

[aschempp]

Any reason this is a separate extension and not in our default ContaoExtension like the other stuff?

I initially had it in there. But I don't know why everything is in one instead of split by topic? I feld like adding yet another constructor injection felt kinda bad style?

[m-vo]

Why constructor injection? We're using runtimes for nearly everything which already separates stuff (and makes it lazy). The only reason for another extension would IMHO be if this will be put in another bundle or users could use it individually.

[ausi]

I agree with @m-vo here, the generate() method and the is_safe_callback should be in a new ContentUrlRuntime service and the TwigFunction should be registered in the ContaoExtension. Same as we did for all other Twig functions and filters.

[aschempp]

You mean like this?

[ausi]

You mean like this?

Yes, perfect ❤️

[leofeyer]

Thank you @aschempp.