Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the TemplateTrait::inlineStyle() method #6740

Merged
merged 2 commits into from Jan 19, 2024

Conversation

fritzmg
Copy link
Contributor

@fritzmg fritzmg commented Jan 18, 2024

This introduces a cspInlineStyle method as discussed.

This PR also fixes two bugs that occur if you - for example - have two forms with Contao's captcha on the same page:

  • Previously this would have resulted in two 'unsafe-hashes' sources in the response CSP header.
  • Previously this would have resulted in two of the same hashes in the response CSP header.

@fritzmg fritzmg added the bug label Jan 18, 2024
@fritzmg fritzmg added this to the 5.3 milestone Jan 18, 2024
@fritzmg fritzmg self-assigned this Jan 18, 2024
Toflar
Toflar previously approved these changes Jan 18, 2024
@fritzmg fritzmg changed the base branch from 5.x to 5.3 January 18, 2024 20:01
@fritzmg fritzmg dismissed Toflar’s stale review January 18, 2024 20:01

The base branch was changed.

@leofeyer leofeyer changed the title Introduce cspInlineStyle method Add the TemplateTrait::inlineStyle() method Jan 19, 2024
@leofeyer leofeyer merged commit 8623c90 into contao:5.3 Jan 19, 2024
17 checks passed
@leofeyer
Copy link
Member

Thank you @fritzmg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants