Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the z-index of the jump targets #6747

Merged
merged 10 commits into from Jan 25, 2024

Conversation

zoglo
Copy link
Contributor

@zoglo zoglo commented Jan 19, 2024

Fixes #6746

A z-index of 1 should be sufficient for .jump-targets, we could also raise the z-index of the dropdown-menu instead.

@leofeyer
Copy link
Member

I doubt that this works. Do the jump targets still overlay the rich text editor with z-index: 1?

@leofeyer leofeyer added bug and removed feature labels Jan 19, 2024
@leofeyer leofeyer added this to the 5.3 milestone Jan 19, 2024
@leofeyer leofeyer linked an issue Jan 19, 2024 that may be closed by this pull request
@zoglo
Copy link
Contributor Author

zoglo commented Jan 19, 2024

I doubt that this works. Do the jump targets still overlay the rich text editor with z-index: 1?

Fixed in 3a72ff

See:
image
image

@leofeyer Seems like the codecov checks failed due to a 503 🤔? Could you re-run it from your side?

[2024-01-19T17:21:57.096Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 503 - upstream connect error or disconnect/reset before headers. reset reason: connection failure```

@zoglo zoglo changed the title Fix z-index on .jump-targets Increase z-index for user dropdown Jan 19, 2024
@zoglo zoglo changed the title Increase z-index for user dropdown Increase z-index for user-dropdown Jan 19, 2024
@zoglo
Copy link
Contributor Author

zoglo commented Jan 20, 2024

Added more comments for higher z-index as well

ausi
ausi previously approved these changes Jan 21, 2024
Copy link
Member

@leofeyer leofeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes work, however, the TinyMCE popup menus use z-index: 1300:


Do we care about that? We could fix it by using z-index: 1332 for the drop-down menu and z-index: 1331 for the jump to links and the submit buttons:

@ausi
Copy link
Member

ausi commented Jan 22, 2024

Do we care about that?

I would leave it as it is, as these menus only open on direct user interaction. For small screens this would even increase the usability of the menus.

@leofeyer leofeyer changed the title Increase z-index for user-dropdown Increase the z-index of the jump targets Jan 25, 2024
@leofeyer leofeyer enabled auto-merge (squash) January 25, 2024 11:04
@leofeyer
Copy link
Member

Thank you @zoglo.

@leofeyer leofeyer merged commit 3f7ba15 into contao:5.3 Jan 25, 2024
17 checks passed
@zoglo zoglo deleted the bugfix/jump-targets-z-index branch January 25, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jump-targets have higher z-index than dropdown-menu
3 participants