Handle routing exceptions during news and event URL generation #6854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 6, 2024
leofeyer
reviewed
Feb 6, 2024
|
As discussed today we should instead catch the routing's |
fritzmg
changed the title
|
FAQ and newsletters already handled routing exceptions during URL generation (and fall back to the current request URL), so I haven't touched those. |
aschempp
reviewed
Feb 8, 2024
aschempp
approved these changes
Feb 16, 2024
leofeyer
changed the title
|
Thank you @fritzmg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first draft on how #6797 could be fixed - in this case for news as an example. @aschempp is this what you had in mind?