Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly initialize multiple accordions on the same page #6867

Merged
merged 1 commit into from Feb 8, 2024
Merged

Correctly initialize multiple accordions on the same page #6867

merged 1 commit into from Feb 8, 2024

Conversation

leofeyer
Copy link
Member

@leofeyer leofeyer commented Feb 7, 2024

Fixes #6864

@leofeyer leofeyer added the bug label Feb 7, 2024
@leofeyer leofeyer added this to the 5.3 milestone Feb 7, 2024
@leofeyer leofeyer self-assigned this Feb 7, 2024
@leofeyer leofeyer requested a review from a team February 7, 2024 11:30
@leofeyer leofeyer linked an issue Feb 7, 2024 that may be closed by this pull request
multiple accordions won't work #6864
Closed
aschempp
aschempp approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@aschempp aschempp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, we previously had a field for custom names to control different accordion settings. I guess that's no longer possible?

@leofeyer leofeyer merged commit 2a0bedc into contao:5.3 Feb 8, 2024
18 checks passed
@leofeyer leofeyer deleted the fix/accordion branch February 8, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ausi ausi ausi approved these changes

@Toflar Toflar Toflar approved these changes

@aschempp aschempp aschempp approved these changes

Assignees

@leofeyer leofeyer

Labels
bug
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.

multiple accordions won't work
4 participants
@leofeyer @ausi @Toflar @aschempp