Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move adding the schema.org data to the _download.html.twig component #6893

Merged
merged 1 commit into from Feb 15, 2024
Merged

Move adding the schema.org data to the _download.html.twig component #6893

merged 1 commit into from Feb 15, 2024

Conversation

leofeyer
Copy link
Member

Fixes #6888

@leofeyer leofeyer added the bug label Feb 14, 2024
@leofeyer leofeyer added this to the 5.3 milestone Feb 14, 2024
@leofeyer leofeyer self-assigned this Feb 14, 2024
@leofeyer leofeyer requested a review from m-vo February 14, 2024 08:48
@leofeyer leofeyer mentioned this pull request Feb 14, 2024
Closed
@leofeyer leofeyer linked an issue Feb 14, 2024 that may be closed by this pull request
Missing add_schema_org in download.html.twig #6888
Closed
@Toflar
Copy link
Member

Toflar commented Feb 14, 2024

LGTM, @contaoacademy does that fix your issue?

@contaoacademy
Copy link

Works, as far as I have tested.

@leofeyer leofeyer merged commit 50dbfa2 into contao:5.3 Feb 15, 2024
18 checks passed
@leofeyer leofeyer deleted the fix/download-schema branch February 15, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Toflar Toflar Toflar approved these changes

@m-vo m-vo m-vo approved these changes

Assignees

@leofeyer leofeyer

Labels
bug
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.

Missing add_schema_org in download.html.twig
4 participants
@leofeyer @Toflar @contaoacademy @m-vo