Add type="button"
to the accordion toggler
#6898
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you happen to insert an accordion content element in a form, e.g. in an HTML code form field with the
{{insert_content::*}}
insert tag, the toggler of the accordion will currently submit the form when clicked, instead of just opening/closing the accordion.This is because any
<button>
without a specifictype
will be treated as atype="submit"
button by default: https://html.spec.whatwg.org/multipage/form-elements.html#the-button-elementSince our toggler button is not supposed to submit anything but rather just act "as a button", it needs
type="button"
.