Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deferred images in HTML emails #693

Merged
merged 3 commits into from
Sep 5, 2019
Merged

Fix deferred images in HTML emails #693

merged 3 commits into from
Sep 5, 2019

Conversation

ausi
Copy link
Member

@ausi ausi commented Aug 30, 2019

Fixes #680

Better name for $objFile->generateIfDeferredImage()?
createDeferredImage(), generateDeferredImage(), createImageIfDeferred() ?

@ausi ausi added the bug label Aug 30, 2019
@ausi ausi added this to the 4.8 milestone Aug 30, 2019
@ausi ausi self-assigned this Aug 30, 2019
@leofeyer
Copy link
Member

I'd go with createDeferredImage().

@leofeyer leofeyer mentioned this pull request Aug 30, 2019
Closed
@leofeyer leofeyer merged commit 5e1d091 into contao:4.8 Sep 5, 2019
@leofeyer
Copy link
Member

leofeyer commented Sep 5, 2019

Thank you @ausi.

@m-vo m-vo mentioned this pull request Oct 1, 2019
Merged
@ausi ausi deleted the fix/newsletter-images branch December 3, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofeyer leofeyer leofeyer left review comments

Assignees

@ausi ausi

Labels
bug
Projects
None yet
Milestone
4.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ausi @leofeyer