Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly implement the ImageFactoryInterface #6939

Merged
merged 2 commits into from Feb 27, 2024
Merged

Correctly implement the ImageFactoryInterface #6939

merged 2 commits into from Feb 27, 2024

Conversation

leofeyer
Copy link
Member

We updated the method signatures of the ImageFactoryInterface in Contao 5 but it seems we forgot to update the ImageFactory class accordingly.

@leofeyer leofeyer added the bug label Feb 26, 2024
@leofeyer leofeyer added this to the 5.3 milestone Feb 26, 2024
@leofeyer leofeyer self-assigned this Feb 26, 2024
@leofeyer leofeyer requested a review from a team February 26, 2024 16:35
bytehead
bytehead previously approved these changes Feb 26, 2024
View reviewed changes
@ausi
Copy link
Member

ausi commented Feb 26, 2024

We can probably also remove $path = (string) $path; on line 72 then.

@leofeyer
Copy link
Member Author

Of course. Removed in bdd2527.

@leofeyer leofeyer requested a review from ausi February 26, 2024 17:25
@leofeyer leofeyer merged commit 0eac53c into contao:5.3 Feb 27, 2024
17 checks passed
@leofeyer leofeyer deleted the fix/image-factory branch February 27, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ausi ausi ausi approved these changes

@bytehead bytehead bytehead left review comments

Assignees

@leofeyer leofeyer

Labels
bug
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leofeyer @ausi @bytehead