Improve the performance of the database dumper #6946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toflar
commented
Feb 27, 2024
leofeyer
reviewed
Feb 27, 2024
aschempp
previously approved these changes
Feb 28, 2024
leofeyer
approved these changes
Feb 28, 2024
leofeyer
changed the title
|
Thank you @Toflar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like with the latest changes in Doctrine DBAL a lot of internal deprecations are suppressed because it uses
getWrappedConnection()insidequote()itself. Also, it seems to do in-memory caching there as well.By reducing the calls to
quote()and using an in-memory cache ourselves, we can cut both, the time needed to create a backup and the memory usage in half 馃コ