Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the dotenv:dump command #6969

Merged
merged 2 commits into from Mar 8, 2024
Merged

Fix the dotenv:dump command #6969

merged 2 commits into from Mar 8, 2024

Conversation

aschempp
Copy link
Member

@aschempp aschempp commented Mar 5, 2024

This will dynamically dump APP_ENV=jwt into the .env.local.php file, if the .env and .env.local do not contain APP_ENV.

@aschempp aschempp added the bug label Mar 5, 2024
@aschempp aschempp added this to the 5.3 milestone Mar 5, 2024
@aschempp aschempp requested a review from Toflar March 5, 2024 15:49
@aschempp aschempp self-assigned this Mar 5, 2024
@Toflar Toflar added the up for discussion Issues and PRs which will be discussed in our monthly Mumble calls. label Mar 5, 2024
@Toflar
Copy link
Member

Toflar commented Mar 5, 2024

Let's discuss this on Thursday, that's way easier and quicker.

@fritzmg
Copy link
Contributor

fritzmg commented Mar 5, 2024

One thing I notice is that while dotenv:dump now dumps APP_ENV=jwt to the PHP file, dotenv:dump prod still dumps APP_ENV=prod to the PHP file - though that may be intentional anyway?

@fritzmg
Copy link
Contributor

fritzmg commented Mar 5, 2024

Other than that everything seems to work now as far as I tested 👍

@leofeyer leofeyer mentioned this pull request Mar 5, 2024
Merged
fritzmg
fritzmg previously approved these changes Mar 7, 2024
View reviewed changes
@leofeyer
Copy link
Member

leofeyer commented Mar 7, 2024

As discussed in the Contao call, we want to keep the factory and merge the PR as it is.

@leofeyer leofeyer removed the up for discussion Issues and PRs which will be discussed in our monthly Mumble calls. label Mar 7, 2024
@leofeyer leofeyer changed the title Fix the environment dump command Fix the dotenv:dump command Mar 8, 2024
@leofeyer leofeyer merged commit 8a6034e into contao:5.3 Mar 8, 2024
17 checks passed
@leofeyer
Copy link
Member

leofeyer commented Mar 8, 2024

Thank you @aschempp.

@aschempp aschempp deleted the fix/env branch March 8, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Toflar Toflar Toflar approved these changes

@fritzmg fritzmg fritzmg left review comments

Assignees

@aschempp aschempp

Labels
bug
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aschempp @Toflar @fritzmg @leofeyer