Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the fragment registry in the debug:fragments command #7006

Merged
merged 9 commits into from Mar 20, 2024
Merged

Use the fragment registry in the debug:fragments command #7006

merged 9 commits into from Mar 20, 2024

Conversation

bytehead
Copy link
Member

@bytehead bytehead commented Mar 12, 2024 •
edited

Preparation PR to fix the issue #6471 afterwards.

@bytehead bytehead added the bug label Mar 12, 2024
@bytehead bytehead added this to the 5.3 milestone Mar 12, 2024
@bytehead bytehead self-assigned this Mar 12, 2024
@bytehead bytehead linked an issue Mar 12, 2024 that may be closed by this pull request
Fragment priority when reusing the same identifier #6471
Open
@bytehead bytehead changed the title Use dedicated fragment registry for debug:fragments command Use the dedicated fragment registry for debug:fragments command Mar 12, 2024
@bytehead bytehead removed a link to an issue Mar 12, 2024
Fragment priority when reusing the same identifier #6471
Open
@bytehead bytehead marked this pull request as ready for review March 12, 2024 12:52
@bytehead bytehead requested a review from m-vo March 12, 2024 12:52
m-vo
m-vo previously approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@m-vo m-vo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think I would rewrite the foreach loop to directly iterate over keys and values, though (see suggestions).

core-bundle/src/Command/DebugFragmentsCommand.php Outdated Show resolved Hide resolved
core-bundle/src/Command/DebugFragmentsCommand.php Outdated Show resolved Hide resolved
core-bundle/src/Command/DebugFragmentsCommand.php Outdated Show resolved Hide resolved
@bytehead @m-vo
Update core-bundle/src/Command/DebugFragmentsCommand.php
a5d730f 
Co-authored-by: M. Vondano <m-vo@users.noreply.github.com>
@bytehead bytehead requested a review from m-vo March 20, 2024 12:45
@leofeyer leofeyer changed the title Use the dedicated fragment registry for debug:fragments command Use the fragment registry in the debug:fragments command Mar 20, 2024
@leofeyer leofeyer merged commit 87981e3 into contao:5.3 Mar 20, 2024
16 of 17 checks passed
@leofeyer
Copy link
Member

Thank you @bytehead.

@bytehead bytehead deleted the fix/fragment-priority branch March 20, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-vo m-vo m-vo approved these changes

Assignees

@bytehead bytehead

Labels
bug
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bytehead @leofeyer @m-vo