Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return to the list view after adding items to the clipboard #7007

Merged
merged 1 commit into from Mar 12, 2024

Conversation

aschempp
Copy link
Member

A move or copy operation currently has a href like act=paste&mode=copy&children=1. When clicking the button, DC_Table will execute the act = paste handler, but render the view again because no actual action is given. But this means the act=paste&mode=copy will remain in the URL, even though is is completely unnecessary, because DC_Table will check the session for the clipboard information.

Having the properties in the URL however breaks all operations that do not explicitly remove them, e.g. moving to child records of a nested element.

I think we can safely return to the list view after copying, same as we do when selecting multiple records to copy.

@aschempp aschempp added the bug label Mar 12, 2024
@aschempp aschempp added this to the 5.3 milestone Mar 12, 2024
@aschempp aschempp requested a review from a team March 12, 2024 12:16
@aschempp aschempp self-assigned this Mar 12, 2024
@leofeyer leofeyer changed the title Return to DC view after adding items to clipboard Return to the list view after adding items to the clipboard Mar 12, 2024
@leofeyer leofeyer merged commit f3d1444 into contao:5.3 Mar 12, 2024
18 checks passed
@leofeyer
Copy link
Member

Thank you @aschempp.

@aschempp aschempp deleted the fix/dc-paste branch March 14, 2024 10:12
leofeyer added a commit that referenced this pull request Mar 22, 2024
@ausi
Copy link
Member

ausi commented Mar 22, 2024

This was reverted in 4f39db3 so we probably need to reopen?

@leofeyer
Copy link
Member

You cannot reopen merged pull requests. We can only reference it in a new issue.

@ausi
Copy link
Member

ausi commented Mar 22, 2024

@aschempp should we create a new issue for this? How can this issue be reproduced?

aschempp added a commit to aschempp/contao that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants