Update the DBAFS cache when creating files #7029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofeyer
reviewed
Mar 20, 2024
Toflar
reviewed
Mar 20, 2024
There was a problem hiding this comment.
In my case, the listContents() did also not work after writing, which is why I had to change this line (https://github.com/contao/contao/pull/6973/files#diff-29a707fd9a3ce791f30b7313fbf90c20eb457d0383b681eea3d6d3c7fa2f9589R158). But maybe with unsetting the records, this works now. In any case, we should probably add a test for that on top, wdyt?
Toflar
previously approved these changes
Mar 20, 2024
leofeyer
approved these changes
Mar 20, 2024
leofeyer
changed the title
|
Thank you @m-vo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I agree with the general idea of the changes in #6973. IMHO we should keep generating cache entries lazy, though + the fix must also be applied to 4.13. This is why I created this PR as an alternative.
/cc @Toflar