Revert the changes to the "file uploaded" check #7039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritzmg
changed the title
|
Failing test is unrelated. |
ausi
approved these changes
Mar 21, 2024
Toflar
approved these changes
Mar 21, 2024
leofeyer
changed the title
|
Thank you @fritzmg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With file uploads you can (could) control via
'uploaded' => true/falsewhether the file will be attached in the email sent byContao\Formor whether it will include a link instead.However the check for this was changed in #4364 from
to
meaning that you cannot control this behavior via
true/falseanymore. Now the file will always be inserted as a link only as soon as the'uploaded'key is present in the files array.This PR reverts the check to the previous behavior, so that this can be controlled more easily again.