Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug in setIfExists() with Stringable objects #7045

Merged
merged 1 commit into from Mar 22, 2024
Merged

Fix a bug in setIfExists() with Stringable objects #7045

merged 1 commit into from Mar 22, 2024

Conversation

ausi
Copy link
Member

@ausi ausi commented Mar 21, 2024

setIfExists() always considered Stringables to be “existing” even if they resolve to the empty string.

@ausi ausi added the bug label Mar 21, 2024
@ausi ausi added this to the 5.3 milestone Mar 21, 2024
@ausi ausi requested a review from m-vo March 21, 2024 21:54
@ausi ausi self-assigned this Mar 21, 2024
m-vo
m-vo approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@m-vo m-vo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@leofeyer leofeyer changed the title Fix bug in setIfExists with Stringable objects Fix bug in setIfExists() with Stringable objects Mar 22, 2024
@leofeyer leofeyer changed the title Fix bug in setIfExists() with Stringable objects Fix a bug in setIfExists() with Stringable objects Mar 22, 2024
@leofeyer leofeyer merged commit 6156318 into contao:5.3 Mar 22, 2024
18 checks passed
@leofeyer
Copy link
Member

Thank you @ausi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Toflar Toflar Toflar approved these changes

@m-vo m-vo m-vo approved these changes

Assignees

@ausi ausi

Labels
bug
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ausi @leofeyer @Toflar @m-vo