Make the member group voter cacheable #7089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toflar
approved these changes
Apr 5, 2024
leofeyer
reviewed
Apr 9, 2024
leofeyer
changed the title
leofeyer
approved these changes
Apr 18, 2024
|
Thank you @aschempp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in the profiler that our
MemberGroupVoterwas asked for a decision for totally unrelated attributes. That's because it did not correctly implement theCacheableVoterInterface, it did not limit the attributes it wanted to vote on. This PR fixes that by not using the unnecessary abstract and correctly onlysupportsAttributeon what we want.