Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a migrations command #709

Merged
merged 36 commits into from
Jan 6, 2020
Merged

Add a migrations command #709

merged 36 commits into from
Jan 6, 2020

Conversation

ausi
Copy link
Member

@ausi ausi commented Sep 2, 2019 •
edited
Loading

See contao/core-bundle#1223 (comment)

Todo:

  • Tests
  • Use migrations service in the install tool

@ausi ausi added the feature label Sep 2, 2019
@ausi ausi added this to the 4.9 milestone Sep 2, 2019
@ausi ausi self-assigned this Sep 2, 2019
@leofeyer leofeyer mentioned this pull request Sep 3, 2019
Merged
5 tasks
@m-vo m-vo mentioned this pull request Oct 12, 2019
Merged
2 tasks
ausi and others added 13 commits December 8, 2019 11:48
@ausi @xchs
Fix typo
8de6fc6 
Co-Authored-By: Hannes <xchs@gmx-topmail.de>
@ausi @xchs
Fix typo
a0b5007 
Co-Authored-By: Hannes <xchs@gmx-topmail.de>
@ausi
Merge branch master into feature/migrate-command
35fb913 
Conflicts:
	core-bundle/src/ContaoCoreBundle.php
	core-bundle/src/DependencyInjection/ContaoCoreExtension.php
	core-bundle/src/Resources/config/services.yml
	installation-bundle/src/Database/Version330Update.php
	installation-bundle/src/Database/Version350Update.php
	installation-bundle/src/Database/Version400Update.php
	installation-bundle/src/Database/Version410Update.php
	installation-bundle/src/Database/Version430Update.php
	installation-bundle/src/Database/Version440Update.php
	installation-bundle/src/Database/Version447Update.php
	installation-bundle/src/Database/Version450Update.php
	installation-bundle/src/Database/Version460Update.php
	installation-bundle/src/Database/Version470Update.php
	installation-bundle/src/Database/Version480Update.php
	installation-bundle/src/Resources/config/services.yml
@ausi
Fix tests
58f6bbe
@ausi
Add SQL execution section headline
2eca5b7
@ausi
Use migrations service in the install tool
db40d3c
@ausi
Run the CS fixer
045b076
@ausi
Add tests
3b0d0a9
@ausi
Merge branch 'master' into feature/migrate-command
2a09f23
@ausi
Improve command test
9a83a6e
@ausi
Fix tests
f1a9184
@ausi
Improve tests
4d61c5d
@ausi
Coding style
1b4728c
@ausi ausi marked this pull request as ready for review December 14, 2019 20:49
@ausi
Copy link
Member Author

ausi commented Dec 22, 2019

I don't like Migrations either. Imho this is a MigrationCollection and the method should be named runAll().

Renamed in fc52190. runAll() would be misleading IMO because only pending migrations get exectued, not all. I renamed to run() now, runPending() would be OK too I think.

Should we add a deprecation notice to the AbstractVersionUpdate class?

Done in 23ec58b.

I think all comments should be addressed now. @aschempp please take a look at your review comments and mark them as resolved if you agree with my changes.

@ausi ausi mentioned this pull request Dec 22, 2019
Merged
2 tasks
@ausi
Copy link
Member Author

ausi commented Dec 22, 2019

please also provide a PR for the documentation :)

Docs pull request: contao/docs#205

@leofeyer leofeyer mentioned this pull request Dec 23, 2019
Closed
@leofeyer leofeyer changed the title Add migrations command Add a migrations command Dec 23, 2019
Toflar
Toflar previously approved these changes Jan 3, 2020
View reviewed changes
aschempp
aschempp previously approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@aschempp aschempp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to use the FQCN instead of the generated name, but I‘m also fine with merging as is 👍🏻

@ausi ausi dismissed stale reviews from aschempp and Toflar via a6d2b26 January 3, 2020 17:10
@ausi
Copy link
Member Author

ausi commented Jan 4, 2020

I would suggest to use the FQCN instead of the generated name

Done in a6d2b26

Toflar
Toflar previously approved these changes Jan 4, 2020
View reviewed changes
@leofeyer leofeyer merged commit a2d0e52 into master Jan 6, 2020
@leofeyer leofeyer deleted the feature/migrate-command branch January 6, 2020 15:23
@leofeyer
Copy link
Member

leofeyer commented Jan 6, 2020

Thank you @ausi.

@Toflar
Copy link
Member

Toflar commented Jan 6, 2020

This is biiiiig!! ❤️ 🎉

@bytehead
Copy link
Member

bytehead commented Jan 6, 2020

Thank you big time @ausi! 😍

@loilo loilo mentioned this pull request Feb 24, 2020
Closed
@ausi ausi mentioned this pull request Apr 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Toflar Toflar Toflar left review comments

@bytehead bytehead bytehead left review comments

@leofeyer leofeyer leofeyer approved these changes

@xchs xchs xchs left review comments

@fritzmg fritzmg fritzmg left review comments

@aschempp aschempp aschempp left review comments

Assignees

@ausi ausi

Labels
feature
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ausi @fritzmg @Toflar @leofeyer @bytehead @aschempp @xchs