Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure compatibility with Twig 3.9 #7123

Merged
merged 4 commits into from Apr 17, 2024
Merged

Conversation

leofeyer
Copy link
Member

Fixes #7121

Requires that twigphp/Twig#4023 is merged and Twig 3.9.1 is released first.

@leofeyer leofeyer added the bug label Apr 17, 2024
@leofeyer leofeyer added this to the 4.13 milestone Apr 17, 2024
@leofeyer leofeyer self-assigned this Apr 17, 2024
@leofeyer leofeyer changed the title Twig 3.9 compatibility Ensure compatibility with Twig 3.9 Apr 17, 2024
@leofeyer leofeyer requested a review from a team April 17, 2024 09:52
@leofeyer leofeyer linked an issue Apr 17, 2024 that may be closed by this pull request
@leofeyer leofeyer requested review from ausi and removed request for a team April 17, 2024 13:28
@leofeyer leofeyer merged commit d570ac5 into contao:4.13 Apr 17, 2024
17 of 18 checks passed
@leofeyer leofeyer deleted the fix/twig-3.9-4.13 branch April 17, 2024 14:14
leofeyer pushed a commit that referenced this pull request Apr 18, 2024
…7129)

Description
-----------

Followup to #7122 and #7123

Probably needs to be backported to Contao 4.13.

@aschempp can you verify that this fixes your issue (`fe_page.html.twig` extending `fe_page.html5`)

Commits
-------

70605f4 Fix Twig 3.9 compatibility of PhpTemplateProxyNode
d55b2af Fix test
7258bee Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't access backend after upgrade to 4.13.41
2 participants