Do not trigger the PHP header() deprecation for certain headers
#7225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ausi
reviewed
May 18, 2024
Co-authored-by: Martin Auswöger <martin@auswoeger.com>
ausi
reviewed
May 24, 2024
Co-authored-by: Martin Auswöger <martin@auswoeger.com>
ausi
previously approved these changes
May 24, 2024
leofeyer
approved these changes
May 24, 2024
leofeyer
changed the title
MergeHttpHeadersListener deprecation for certain headersPHP header() deprecation for certain headers
leofeyer
changed the title
PHP header() deprecation for certain headersheader() deprecation for certain headers
|
Thank you @fritzmg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a session is started when using the
NativeSessionStorage(which is the default) orexpose_phpis not set toOff/0, the following deprecation is always triggered:There can always be headers that bypass the response object from Symfony. This PR at least ignores the
Set-Cookie: PHPSESSID=andX-Powered-Byheaders.