-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework the messenger integration #7253
Conversation
c264ab0
to
4749d24
Compare
4749d24
to
b9af073
Compare
@ausi this is almost ready for review. There's a problem with your |
Yes, it should be added to the ignore list here:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
(Did not test it manually)
Co-authored-by: Leo Feyer <1192057+leofeyer@users.noreply.github.com>
Thank you @Toflar. |
Fixes #7251
SyncTransport
before is now automatically delayed to thekernel.terminate
event providing an advantage for all users (that have access tofastcgi_finish_request()
), not only the ones that have the cronjob configured.You cannot call ack() on the Messenger SyncTransport.
no matter the grace period because the transport configuration does not change anymore.I've split deleting the old logic and the new in two commits so that it's easier to review.
Remarks:
*Listener
classes because they would all be one-liners forwarding to theWebWorker
service. Now, all the magic is part of theWebWorker
which makes it way easier to understand and see what's going on. I know we have*Listener
classes for almost everything else but I strongly suggest to not do that in this case. It also makes removing the one single service from the container super easy in case no transport is configured to use the web worker (core-bundle
standalone default).