Remove the process timeout in the SuperviseWorkersCommand
#7262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ausi
reviewed
Jun 4, 2024
ausi
reviewed
Jun 4, 2024
ausi
reviewed
Jun 4, 2024
Toflar
previously approved these changes
Jun 4, 2024
leofeyer
approved these changes
Jun 6, 2024
leofeyer
changed the title
SuperviseWorkersCommand
|
Thank you @md-netdesign. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7260
The process timeout for the supervisor command and it's workers is removed when invoked via the cron framework to allow for long running messages and prevent orphaned temporary php.ini files, due to the killed worker processes, when the supervisor command is timed out.
The 60 seconds time limit for the workers is not touched, so they will shutdown after 60 seconds or after processing the last messages started before the 60 second limit.