Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ID always searchable in DC_Table #7275

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Conversation

Toflar
Copy link
Member

@Toflar Toflar commented Jun 11, 2024

Problem:

  1. Go to https://demo.contao.org/contao?do=form
  2. Try to search for Form ID 3
  3. You won't get any results.

The reason for that is that Form ID relates to the HTML ID and not the database ID. This is confusing because e.g. in tl_article or tl_page you can search for the database ID so you expect to be able to do that in forms as well.

I think the easiest fix for that problem is to allow searching for the database ID for form related stuff as well.

@Toflar Toflar marked this pull request as ready for review June 11, 2024 08:48
@Toflar Toflar self-assigned this Jun 11, 2024
@Toflar Toflar added the bug label Jun 11, 2024
@Toflar Toflar added this to the 4.13 milestone Jun 11, 2024
fritzmg
fritzmg previously approved these changes Jun 11, 2024
@Toflar Toflar changed the title Fix searching for form data IDs Make ID always searchable in DC_Table Jun 18, 2024
@Toflar
Copy link
Member Author

Toflar commented Jun 18, 2024

Updated, now id is always searchable. The label definition is useless as well because ID is the default :)

Copy link
Member

@leofeyer leofeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 🎉

@leofeyer leofeyer enabled auto-merge (squash) June 19, 2024 09:41
@leofeyer
Copy link
Member

Thank you @Toflar.

@leofeyer leofeyer merged commit b2effe8 into contao:4.13 Jun 19, 2024
18 checks passed
@Toflar Toflar deleted the fix/search-form-id branch June 19, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants