-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Lucide icons in the back end #7278
Conversation
9f4ff04
to
ff41bf3
Compare
ff41bf3
to
cc28f43
Compare
I‘m quite happy with the new icons except for the "edit child records" one. Maybe someone has a better idea regarding both the icon and the color. |
Will the new icons also be integrated into the 5.3 LTS? |
No, it's a new feature. |
I‘d rather keep the current icon, because
Like this?
I cannot reproduce. Can you make a screenshot?
I cannot reproduce this, either. Maybe a browser cache problem?
They have always been:
This is intentional. You only need to know that it is a redirect page; whether the redirect is internal or external is a detail that does not need to be reflected in the status icon. |
c3f8ba0
to
408a154
Compare
I have to disagree here, this is a rather important distinction. |
No, it is not. We even discussed merging the two page types because it really makes no sense to have both. |
In the absence of a folder page you typically use the internal redirect redirect page when creating a folder structure in your site structure, for menu items that are only there to contain other menu icons (and show them on hover for the desktop for example). The internal redirect also redirects you automatically to its first child, if no redirect page is selected. In the external redirect page you have to define any arbitrary URL. It does not have any special logic. Using it as a container as described above makes no sense, as the target URL is mandatory. Merging the two also does not make any sense to me, at least currently. As long as we have both it also important to be able to visually distinguish between the two. (i.e. having links to external resources, like links to social pages etc., should be clearly distinguishable from the other pages). |
unless that "something" resembles a local disk 🙈 |
essential feature - don't remove that please! |
That is because you upload the file to be imported and you download the file to be exported. |
There are no plans to remove any functionality! A unified redirect page type could also provide the "redirect to first child" feature. |
Fixed in 408a154.
It is. You have to compare against its disabled state: |
For consistency, we should use the same icon as for the other import actions. Fixed in 9254063. |
Changed in b43708b. |
c43af32
to
49a2b57
Compare
All suggestions have been addressed. I will now merge the PR so I can start working on the follow-up PRs. If you find any other problem, please create a new issue on GitHub. |
Implements #7091