Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use classnames instead of service IDs #763

Closed
wants to merge 8 commits into from

Conversation

leofeyer
Copy link
Member

@leofeyer leofeyer commented Sep 16, 2019

This PR replaces the contao. service IDs with class names as recommended in Symfony 4.

TODO

  • Also convert the private services
  • Add aliases for the private services
  • Check for ->getDefinition()->getClass(), which now returns null

@leofeyer leofeyer added this to the 4.9 milestone Sep 16, 2019
@leofeyer leofeyer self-assigned this Sep 16, 2019
@leofeyer leofeyer closed this Sep 17, 2019
@leofeyer leofeyer deleted the feature/service-aliases branch September 17, 2019 08:08
@leofeyer leofeyer removed the feature label Sep 17, 2019
@leofeyer leofeyer removed this from the 4.9 milestone Sep 17, 2019
@aschempp
Copy link
Member

There's a looot of changes here. Before we review every file, am I correct that you did not add aliases for all current services? Because I think we should, regardless of whether they should have been used or not…
Also, can/should be add deprecated to the aliased services? Or is that even possible?

@leofeyer
Copy link
Member Author

This PR has been closed as the concept does not really work for a bundle. All the fancy stuff such as service annotations or autowiring (which is what class names as service IDs is mainly for) work best in your app.

@aschempp
Copy link
Member

I don't understand why that would not work in our bundle?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants