Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify registering custom fragment types #776

Merged
merged 3 commits into from Sep 20, 2019
Merged

Simplify registering custom fragment types #776

merged 3 commits into from Sep 20, 2019

Conversation

aschempp
Copy link
Member

No description provided.

@aschempp aschempp added this to the 4.9 milestone Sep 19, 2019
@aschempp aschempp self-assigned this Sep 19, 2019
@leofeyer
Copy link
Member

So is it still necessary (for other reasons than BC) to have the method visibility set to protected instead of private?

@aschempp
Copy link
Member Author

yes, and we'll need that for the insert tags anyway.

@leofeyer leofeyer force-pushed the feature/simple-fragment-registry branch from 33de555 to ea7a961 Compare September 20, 2019 09:02
@leofeyer leofeyer merged commit 8ea56d0 into master Sep 20, 2019
@leofeyer
Copy link
Member

Thank you @aschempp.

@leofeyer leofeyer deleted the feature/simple-fragment-registry branch September 20, 2019 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofeyer leofeyer leofeyer left review comments

@Toflar Toflar Awaiting requested review from Toflar

Assignees

@aschempp aschempp

Labels
feature
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aschempp @leofeyer