Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Allow to output more verbose error messages in contao:resize-images command #866

Merged

Conversation

qzminski
Copy link
Member

Together with @Toflar we had a hard time debugging why the contao:resize-images command stopped at some point and did not want to continue. The error message was quite unclear especially that the requested file existed:

6/77b26349-9084f1ba.jpg......... failed
Unable to open image /var/www/vhosts/domain.tld/httpdocs/releases/233/assets/images/../../var/pim-images/77b26349.jpg

So we decided to introduce an option that allows to output more verbose error message simply by executing command in verbose mode contao:resize-images -v:

f/8ac5c4ec-213df40b.jpg.............. failed

 [ERROR] ImagickException: cache resources exhausted
         `/var/www/vhosts/domain.tld/httpdocs/releases/233/assets/images/../../var/pim-images/8ac5c4ec.jpg' @
         error/cache.c/OpenPixelCache/3864 in
         /var/www/vhosts/domain.tld/httpdocs/releases/233/vendor/imagine/imagine/src/Imagick/Imagine.php:69
         Stack trace:
         #0 /var/www/vhosts/domain.tld/httpdocs/releases/233/vendor/imagine/imagine/src/Imagick/Imagine.php(69):
         Imagick->__construct('/var/www/vhosts...')
         #1 /var/www/vhosts/domain.tld/httpdocs/releases/233/vendor/contao/image/src/Resizer.php(93):
         Imagine\Imagick\Imagine->open('/var/www/vhosts...')
         #2 /var/www/vhosts/domain.tld/httpdocs/releases/233/vendor/contao/image/src/DeferredResizer.php(185):
         Contao\Image\Resizer->executeResize(Object(Contao\Image\Image), Object(Contao\Image\ResizeCoordinates),
         '/var/www/vhosts...', Object(Contao\Image\ResizeOptions))
         #3 /var/www/vhosts/domain.tld/httpdocs/releases/233/vendor/contao/image/src/DeferredResizer.php(108):
         Contao\Image\DeferredResizer->executeDeferredResize('f/8ac5c4ec-213d...', Array,
         Object(Imagine\Imagick\Imagine))
         #4
         /var/www/vhosts/domain.tld/httpdocs/releases/233/vendor/contao/core-bundle/src/Command/ResizeImagesComma
         nd.php(189): Contao\Image\DeferredResizer->resizeDeferredImage(Object(Contao\Image\DeferredImage), false)
         #5
         /var/www/vhosts/domain.tld/httpdocs/releases/233/vendor/contao/core-bundle/src/Command/ResizeImagesComma
         nd.php(166): Contao\CoreBundle\Command\ResizeImagesCommand->resizeImage('f/8ac5c4ec-213d...',
         Object(Symfony\Component\Console\Style\SymfonyStyle))
         #6 /var/www/vhosts/domain.tld/httpdocs/releases/233/vendor/symfony/console/Command/Command.php(255):

@Toflar Toflar requested a review from ausi October 25, 2019 10:22
@Toflar Toflar added this to the 4.8 milestone Oct 25, 2019
@Toflar Toflar added the bug label Oct 25, 2019
@leofeyer leofeyer merged commit 69b1f3b into contao:4.8 Nov 1, 2019
@leofeyer
Copy link
Member

leofeyer commented Nov 1, 2019

Thank you @qzminski.

@leofeyer
Copy link
Member

leofeyer commented Nov 1, 2019

This should have gone into the master branch, because FlattenException::getAsString() does not exist in Symfony 4.2. 😞

@Toflar
Copy link
Member

Toflar commented Nov 1, 2019

I don't think so, no. It's a bugfix because of nonsense output. So it needs to be fixed in 4.8.
However, maybe we need some method_exists() check.

@leofeyer
Copy link
Member

leofeyer commented Nov 1, 2019

See #917.

leofeyer added a commit that referenced this pull request Nov 1, 2019
Description
-----------

Fixes #866

The first change regarding the `$duration` variable has been made to avoid conflicts when merging upstream.

Commits
-------

2a21704 Check if the FlattenException::getAsString() method exists (see #866)
2d23aa5 Adjust the phpstan.neon.dist file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants