Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the "accept" attribute in the upload form field #954

Merged
merged 4 commits into from
Dec 4, 2019
Merged

Set the "accept" attribute in the upload form field #954

merged 4 commits into from
Dec 4, 2019

Conversation

bohnmedia
Copy link

@bohnmedia bohnmedia commented Nov 11, 2019

I was wondering why no "accept"-attribute is set in the file input field, when someone adds allowed extensions. This would prefilter the selectable files on client side and improve the usability.

Adds "accept" attribute to input tag when extensions are set.
ausi
ausi previously approved these changes Nov 14, 2019
Toflar
Toflar previously approved these changes Nov 14, 2019
@leofeyer leofeyer added this to the 4.9 milestone Nov 15, 2019
Co-Authored-By: Andreas Schempp <andreas.schempp@terminal42.ch>
@bohnmedia bohnmedia dismissed stale reviews from Toflar and ausi via ca9505e November 20, 2019 17:37
@leofeyer leofeyer merged commit 2b954be into contao:master Dec 4, 2019
@leofeyer
Copy link
Member

leofeyer commented Dec 4, 2019

Thank you @bohnmedia.

@bohnmedia bohnmedia deleted the patch-1 branch December 4, 2019 15:12
@leofeyer leofeyer changed the title Set attribute "accept" in FormFieldUpload Set the "accept" attribute in the upload form field Jan 10, 2020
@bohnmedia bohnmedia removed their assignment Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants