-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support configuring the SearchIndexListener behaviour #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ausi
previously approved these changes
Nov 14, 2019
leofeyer
reviewed
Nov 15, 2019
I think I would prefer to configure the listener like this: contao:
search:
default_indexer:
enable: true
listener:
index: true
delete: true IMHO this is more understandable and less error-prone than a string. |
Configuration simplified as suggested in cf3de3b. |
All tests pass, merged master too. This should be RTM. |
leofeyer
approved these changes
Nov 27, 2019
Thank you @Toflar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to configure how the
SearchIndexListener
behaves.Right now it updates the index when the response was successful and it deletes it from the index, if it was not.
If you have cronjobs doing that work for you, you may want to disable that listener completely or have it e.g. only delete from the index. You can configure all 4 possible states using the config now: