Implement the contao:crawl command #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs another update for latest Escargot changes. Will work on them tomorrow. |
leofeyer
reviewed
Dec 2, 2019
| $this->indexer->delete($document); | ||
| } | ||
| } catch (IndexerException $e) { | ||
| // Noop |
There was a problem hiding this comment.
Do we not want this to be logged?
There was a problem hiding this comment.
I was thinking about this too but I'm not sure. Right now we don't have any message either so I kept it like that for now.
leofeyer
reviewed
Dec 2, 2019
|
All comments addressed, merged master into the PR. All green 🎉 |
leofeyer
requested changes
Dec 4, 2019
|
|
||
| use Terminal42\Escargot\Subscriber\SubscriberInterface; | ||
|
|
||
| interface EscargotSubscriber extends SubscriberInterface |
There was a problem hiding this comment.
I just noticed that this does not follow our naming conventions. It should be EscargotSubscriberInterface.
There was a problem hiding this comment.
Oh, indeed! Good catch! Fixed in e591905.
Toflar
force-pushed
the
feature/crawl-command
branch
from
e591905
to
e714b07
Compare
leofeyer
approved these changes
Dec 4, 2019
|
Thank you @Toflar. This is huge! 💪 |
leofeyer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sub PR of #981 only containing the CLI variant. It will allow us to focus more on the technical implementation first before we have all UI/CSS changes.