Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented contao:crawl command #985

Merged
merged 21 commits into from Dec 4, 2019
Merged

Implemented contao:crawl command #985

merged 21 commits into from Dec 4, 2019

Conversation

@Toflar
Copy link
Member

Toflar commented Nov 15, 2019

This is a sub PR of #981 only containing the CLI variant. It will allow us to focus more on the technical implementation first before we have all UI/CSS changes.

@Toflar Toflar requested a review from leofeyer Nov 15, 2019
@Toflar

This comment has been minimized.

Copy link
Member Author

Toflar commented Nov 25, 2019

This needs another update for latest Escargot changes. Will work on them tomorrow.

@leofeyer leofeyer added the feature label Dec 2, 2019
@leofeyer leofeyer added this to the 4.9 milestone Dec 2, 2019
$this->indexer->delete($document);
}
} catch (IndexerException $e) {
// Noop

This comment has been minimized.

Copy link
@leofeyer

leofeyer Dec 2, 2019

Member

Do we not want this to be logged?

This comment has been minimized.

Copy link
@Toflar

Toflar Dec 2, 2019

Author Member

I was thinking about this too but I'm not sure. Right now we don't have any message either so I kept it like that for now.

Toflar added 2 commits Dec 2, 2019
CS
@Toflar

This comment has been minimized.

Copy link
Member Author

Toflar commented Dec 4, 2019

All comments addressed, merged master into the PR. All green 🎉

@Toflar Toflar requested a review from leofeyer Dec 4, 2019
Copy link
Member

leofeyer left a comment

Besides the wrong class name, everything looks RTM to me.

use Terminal42\Escargot\Subscriber\SubscriberInterface;
interface EscargotSubscriber extends SubscriberInterface

This comment has been minimized.

Copy link
@leofeyer

leofeyer Dec 4, 2019

Member

I just noticed that this does not follow our naming conventions. It should be EscargotSubscriberInterface.

This comment has been minimized.

Copy link
@Toflar

Toflar Dec 4, 2019

Author Member

Oh, indeed! Good catch! Fixed in e591905.

@Toflar Toflar force-pushed the feature/crawl-command branch from e591905 to e714b07 Dec 4, 2019
@leofeyer leofeyer merged commit 23630c1 into master Dec 4, 2019
9 checks passed
9 checks passed
Coverage
Details
Coding Style
Details
PHP 7.2
Details
PHP 7.3
Details
PHP 7.4
Details
Prefer Lowest
Details
Bundles
Details
Windows
Details
codecov/project 89.16% (+0.03%) compared to dd4ef4b
Details
@leofeyer

This comment has been minimized.

Copy link
Member

leofeyer commented Dec 4, 2019

Thank you @Toflar. This is huge! 💪

@leofeyer leofeyer deleted the feature/crawl-command branch Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.