Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Symfony LockableTrait for commands #618

Closed
aschempp opened this issue Nov 8, 2016 · 2 comments
Closed

Use Symfony LockableTrait for commands #618

aschempp opened this issue Nov 8, 2016 · 2 comments
Labels
feature incompatible

Comments

@aschempp
Copy link
Member

aschempp commented Nov 8, 2016

Symfony 3.2 added a LockableTrait for commands: https://github.com/symfony/console/blob/master/Command/LockableTrait.php

I think this could replace our AbstractLockedCommand.
@leofeyer
Copy link
Member

leofeyer commented Nov 9, 2016

We also need to drop support for Symfony 2.8 (and 3.0 and 3.1) for this, don't we?

@aschempp
Copy link
Member Author

aschempp commented Nov 9, 2016 via email

leofeyer added a commit that referenced this issue Dec 20, 2019
@leofeyer
Do not strip forms in the ModuleArticle::generatePdf() method (see #1…
11969bc 
…123)

Description
-----------

Closes #618 

Complementary commit: contao/tcpdf-bundle@0c377c3

Commits
-------

10c2d6d1 Do not strip forms in the ModuleArticle::generatePdf() method (see #618)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature incompatible
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aschempp @leofeyer