Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance mode automatically deactivated after cache:clear #728

Closed
agoat opened this issue Mar 19, 2017 · 4 comments
Closed

Maintenance mode automatically deactivated after cache:clear #728

agoat opened this issue Mar 19, 2017 · 4 comments
Assignees
Labels
Milestone

Comments

@agoat
Copy link
Contributor

agoat commented Mar 19, 2017

When clearing the symfony cache with php bin/console cache:clear -e prod the status of the maintenance mode is also cleared. Is it possible to change this behaviour?

To stay in maintenance mode after updating and clearing the cache, would be helpfull to check, if everything works properly before open it again for the visitors.

@leofeyer leofeyer added the bug label Mar 20, 2017
@leofeyer leofeyer added this to the 4.3.6 milestone Mar 20, 2017
@leofeyer
Copy link
Member

We must not store the lock file in the Sf cache directory. Here's the default Lexik configuration:

driver:
        options: {file_path: %kernel.root_dir%/cache/lock}

@Toflar
Copy link
Member

Toflar commented Mar 20, 2017

Imho it should just go to var/maintenance_lock or so. :)

@aschempp
Copy link
Member

aschempp commented Mar 20, 2017

Unfortunately the default Lexik configuration is not meant for Symfony 3, but it's correct their lock file is outside the environment cache directory. I think @Toflar's suggestion makes sense, another option might be %kernel.cache_dir%/../(maintenance_)lock

@leofeyer leofeyer modified the milestones: 4.4.0, 4.3.6 Mar 20, 2017
@agoat agoat changed the title Maintenance mode automatically deactivates after cache:clear Maintenance mode automatically deactivated after cache:clear Apr 3, 2017
@leofeyer leofeyer self-assigned this Apr 27, 2017
leofeyer added a commit to contao/standard-edition that referenced this issue Apr 27, 2017
@leofeyer
Copy link
Member

leofeyer commented Apr 27, 2017

leofeyer added a commit to contao/manager-bundle that referenced this issue Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants