Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: DC_Folder does not check for gdlib when generating thumbnails #826

Closed
Toflar opened this issue May 16, 2017 · 6 comments
Closed

Bug: DC_Folder does not check for gdlib when generating thumbnails #826

Toflar opened this issue May 16, 2017 · 6 comments
Assignees
Labels
Milestone

Comments

@Toflar
Copy link
Member

Toflar commented May 16, 2017

This means that gdMaxImgHeight and gdMaxImgWidth are considered even though I use Imagemagick.

@DanielSchwiperich
Copy link
Contributor

composer.json requires ext-gd so running gdlib is necessary I assume

@Toflar
Copy link
Member Author

Toflar commented May 16, 2017

Gd is absolutely not a requirement. That's another bug then :)

@leofeyer leofeyer added the bug label May 16, 2017
@ausi
Copy link
Member

ausi commented May 16, 2017

ext-gd is a requirement until Contao 5.0, see #533 (comment)

But the requirement of GD has nothing to do with the fact that we should ignore gdMaxImgWidth/Height if Imagick or Gmagick is used by the image services. We do this already in the LegacyResizer in src/Image/LegacyResizer.php:122

@ausi
Copy link
Member

ausi commented Jun 6, 2017

With \System::getContainer()->get('contao.image.imagine') instanceof \Imagine\Gd\Imagine

@leofeyer leofeyer assigned leofeyer and unassigned ausi Jun 9, 2017
@leofeyer leofeyer added this to the 4.4.0 milestone Jun 9, 2017
leofeyer added a commit that referenced this issue Jun 9, 2017
@leofeyer
Copy link
Member

leofeyer commented Jun 9, 2017

Fixed in 933f9f4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants