Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepend_locale: why in parameters.yml? #901

Closed
fritzmg opened this issue Jun 26, 2017 · 2 comments
Closed

prepend_locale: why in parameters.yml? #901

fritzmg opened this issue Jun 26, 2017 · 2 comments

Comments

@fritzmg
Copy link
Contributor

fritzmg commented Jun 26, 2017

The parameters.yml of a Symfony application is typically not something that you deploy to your live server for example, since it usually contains configuration parameters for the installation on the current host - e.g. database connection and smtp settings.

But currently it also contains the prepend_locale setting of Contao. If you forget to change that on your deployment target as well, the website will suddenly be without the language in the URL. Other URL related settings like the url_suffix is handled in the config.yml as well, why not the prepand_locale setting too?
@fritzmg fritzmg mentioned this issue Jun 26, 2017
Open
@aschempp
Copy link
Member

Duplicate of contao/standard-edition#65

@fritzmg
Copy link
Contributor Author

fritzmg commented Jun 26, 2017

Sorry, didn't notice.

@fritzmg fritzmg closed this as completed Jun 26, 2017
leofeyer added a commit that referenced this issue Nov 4, 2019
@leofeyer
Reduce the number of DB queries in the picture factory (see #921)
bc067f8 
Description
-----------

Fixes #901

Commits
-------

27e1797b Reduce the number of DB queries in the picture factory (see #901)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aschempp @leofeyer @fritzmg