[RTM] Added insert tag for translator #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit tests are missing but otherwise I'm +1 on that! |
xchs
reviewed
Feb 28, 2018
| * | ||
| * Copyright (c) 2005-2018 Leo Feyer | ||
| * | ||
| * @license LGPL-3.0+ |
leofeyer
changed the title
aschempp
force-pushed
the
feature/trans-inserttag
branch
from
da66db3
to
d1bd88f
Compare
|
Unit tests added. I couldn't run the php-cs-fixer for some reason so the license etc. hasn't been changed. |
aschempp
changed the title
|
Thank you @aschempp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contao 4.5 supports the Symfony translator, but there is no insert tag to use the Symfony translator. Here's a fix for that.
{{trans::foo_bar}}=> Replacefoo_barwith the default message domain (messages), mostly not useful{{trans::foo_bar::app}}=> Replacefoo_barfromappmessage domain{{trans::foo_bar::app::param1:param2}}=> Replacefoo_barfromappmessage domain with parametersparam1andparam2. The parameters are separated by single colons, like they are for thelabelinsert tag.