Only start the session if needed to find data in FORM_DATA #1471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
leofeyer
reviewed
Apr 9, 2018
| if (isset($_SESSION['FORM_DATA'][$strKey])) | ||
| /** @var \Symfony\Component\HttpFoundation\Request $request */ | ||
| $request = System::getContainer()->get('request_stack')->getMasterRequest(); | ||
| if (null !== $request && $request->hasPreviousSession() && isset($_SESSION['FORM_DATA'][$strKey])) |
There was a problem hiding this comment.
Will the isset() check not start the session already?
There was a problem hiding this comment.
PHP will stop evaluating if the second or first condition evaluate to false already no? :)
ausi
approved these changes
Apr 9, 2018
discordier
approved these changes
Apr 10, 2018
aschempp
approved these changes
Apr 10, 2018
|
Thank you @Toflar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.