This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[StyleSheet generator] support data: URIs #3661
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 30, 2011 23:31
…SpecialChars()) and urlencode some to preserve some url() values (including data: URIs)
|
Please fix this in 2.10.4. |
leofeyer
added a commit
that referenced
this pull request
Jan 9, 2012
|
Fixed in 4580aec. You can use data: URIs in Contao 2.10 by adding them to the "Custom CSS code" section and wrapping them in single quotes (') instead of double quotes ("). |
|
Thank you! What about the second commit, i. e. fixing character encoding? Those characters should really be URL-encoded (or literals, at least the equality sign |
|
I didn't know what that was for. Are there missing |
|
2nd paragraph in the initial post ;-).
Probably ;-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the StyleSheet generator adds
../to any url() path without a leading/. This also affectsdata:URIs, which renders them unusable. Thus, I added some more checks.Additionally, I fixed character encoding for url() values: Previously, it was impossible to use e. g.
images.php?id=324e2c&width=32as a background image, or a Widows-style path. This bug also affected somedata:URIs.