patched mediabox.js inconsistent regarding contextmenu

[fritzmg]

Contao's version of the mediabox.js adds the following patch, to enable the contextmenu on image links by default:

// PATCH: enable the contextmenu
//links.addEvent('contextmenu', function(e){
//  if (this.toString().match(/\.gif|\.jpg|\.jpeg|\.png/i)) e.stop();
//});
// PATCH EOF

However, the contextmenu on the actual image is still disabled. In order to enable it, the following line (#900) needs to be disabled:

preload.addEvent('mousedown', function(e){ e.stop(); }).addEvent('contextmenu', function(e){ e.stop(); });

But may be it would be better to upgrade the mediabox to its newest version. mediabox 1.5.x introduces this option:

clickBlock: true, // Adds an event on right-click to block saving of images from the context menu in most browsers (this can't prevent other ways of downloading, but works as a casual deterent).

When clickBlock is false, both the already patched part and the part I mentioned will be disabled.

[Aybee]

Where have you found a version 1.5.x of mediabox?

[fritzmg]

On the website (and Github). However, I just noticed, that there is no stable release yet.

[Aybee]

Yes I know both sites that's why I asked where you found a 1.5 version. I can't find one, no stable and no alpha or beta.

[fritzmg]

The master branch contains the 1.5.x version: https://github.com/iaian7/mediaboxAdvanced/blob/master/Source/mediaboxAdv.js

[Aybee]

Ah, ok, sorry forgot to look at the master. Three years old 😳

[leofeyer]

Too bad the maintainer did not tag their releases, otherwise we would have known that there is a version 1.5 :(

[leofeyer]

I have updated the Contao mediabox component accordingly, however, it requires to adjust the moo_mediabox template and can therefore only be included in Contao 4.

So for Contao 3, I have just commented out line 900 in 46e670f to fix the issue.

[fritzmg]

Sounds good :)