This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Prevent websitePath from overwriting #6811
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The $GLOBALS['TL_CONFIG']['websitePath'] may be set in localconfig.php, in this case some Contao functions, like System::setCookie()* which still use $GLOBALS['TL_CONFIG']['websitePath'] use a wrong path, so no cookie will work in case of wrong cookie path. * https://github.com/contao/core/blob/master/system/modules/core/library/Contao/System.php#L462
|
Damn right you are :( |
leofeyer
pushed a commit
that referenced
this pull request
Mar 21, 2014
|
Merged in 6b0d458. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
$GLOBALS['TL_CONFIG']['websitePath']may be set inlocalconfig.php, in this case some Contao functions, like System::setCookie() which still use$GLOBALS['TL_CONFIG']['websitePath'], so no cookie will work in case of wrong cookie path.