This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Remove inline styles from image captions #7549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No, in #7351 we fixed the inconsistency between As commented in #3517 (comment) the inline styles don’t work great for responsive websites. And because of the new responsive images feature the width of the image is dynamic and the caption width may not match the width of the image. |
leofeyer
added a commit
that referenced
this pull request
Jan 16, 2015
leofeyer
pushed a commit
that referenced
this pull request
Jan 16, 2015
|
Actually merged in 35fe8d9. |
leofeyer
pushed a commit
that referenced
this pull request
Jan 23, 2015
leofeyer
pushed a commit
that referenced
this pull request
Jan 23, 2015
leofeyer
pushed a commit
that referenced
this pull request
Jan 23, 2015
leofeyer
pushed a commit
that referenced
this pull request
Mar 27, 2015
leofeyer
pushed a commit
that referenced
this pull request
Mar 27, 2015
leofeyer
pushed a commit
that referenced
this pull request
Jul 23, 2015
leofeyer
pushed a commit
that referenced
this pull request
Jul 23, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inline styles for image captions don’t make sense anymore. Because of the new responsive images feature the image width is dynamic.
Related: #3517, Forum thread 54806