Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guide on how to install 'test' versions #232

Merged
merged 10 commits into from Feb 1, 2020

Conversation

fritzmg
Copy link
Contributor

@fritzmg fritzmg commented Jan 22, 2020

This adds a guide on how to install release candidates and development versions of Contao.

@fritzmg fritzmg self-assigned this Jan 22, 2020
docs/manual/guides/install-test-versions.de.md Outdated Show resolved Hide resolved
zu lassen, _inklusive_ den neuesten Release Candidates (wenn vorhanden):

```json
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know but I find this way easier:

{
    "require": {
        "contao/manager-bundle": "4.9.*"
    },
    "minimum-stability": "RC",
    "prefer-stable": true
}

It's easy to explain the minimum-stability and prefer-stable flags and all you have to do once the stable release is here is to remove those two lines and you're done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's easier, but also causes a lot more processing time and memory usage within composer. I discussed this with @aschempp too and we agreed that the Contao Manager should also support this approach. @aschempp wdyt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would it use more processing time? It needs about 1.5 minutes in both cases anyway.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want composer to resolve any RC version, we want it for a specific package. That's why we require them… It's also what you'll need to do in the Contao Manager, once we can install core-bundle and installation-bundle.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You won‘t get any other RC version unless there‘s one of any other dependency matching our constraints which is highly unlikely to happen.
I‘ll choose my version over the explicit one any day. Even if it might potentially load an RC of another package, it‘s still way easier to use.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely 4.9.x-dev. Changing the minimum stability will affect all packages, not just the Contao ones!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will only affect them if there's not any stable release of those packages fulfilling the ruleset. That's highly, highly unlikely.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely 4.9.x-dev. Changing the minimum stability will affect all packages, not just the Contao ones!

Well yes, for the dev version of course. But what about the RC? There you can safely lower the minimum-stability to RC, without increasing the memory consumption or processing time of a composer update (too much) and without a big risk of installing release candidates of other packages.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK. I never have this case. 🤷‍♂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have now changed it to the minimum-stability version.

Copy link
Member

@aschempp aschempp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Features würd ich in Funktionen umbenennen (Denglisch)
  • Die "bei neuen Versionen" könnte vielleicht auf Minor-Versionen umformuliert werden, mit einem Hinweis auf Semantic Versioning (www.semver.org).

@fritzmg
Copy link
Contributor Author

fritzmg commented Jan 23, 2020

  • Features würd ich in Funktionen umbenennen (Denglisch)
  • Die "bei neuen Versionen" könnte vielleicht auf Minor-Versionen umformuliert werden, mit einem Hinweis auf Semantic Versioning (www.semver.org).

Beides done.

netzarbeiter
netzarbeiter previously approved these changes Jan 23, 2020
Copy link
Member

@netzarbeiter netzarbeiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @fritzmg

@fritzmg
Copy link
Contributor Author

fritzmg commented Jan 23, 2020

btw. thank you @xchs, mit Beistrichen hab ich's wohl nicht so 😁

@aschempp
Copy link
Member

Damit dir nicht langweilig wird … 🙈 😂
Ich habe eben den Contao Manager 1.2.3 veröffentlicht. Dort lässt sich bei Contao jede Version installieren, also ein Constraint wie ^4.9@RC oder 4.9.x-dev 😎

netzarbeiter
netzarbeiter previously approved these changes Jan 30, 2020
@fritzmg
Copy link
Contributor Author

fritzmg commented Jan 31, 2020

@aschempp I have added a note about how to install it in the Contao Manager. The animated GIF is a bit quick & dirty, but hopefully sufficient ;).

@ausi ausi removed the request for review from Toflar February 1, 2020 10:36
@netzarbeiter netzarbeiter merged commit 8642ee9 into master Feb 1, 2020
@fritzmg fritzmg deleted the manual/guides/install-test-versions branch February 3, 2020 10:27
@aschempp
Copy link
Member

aschempp commented Feb 7, 2020

Love the GIF! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants