New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new section on how to update locally #578
Conversation
I would keep the paragraph "Ausblick" and possibly rename it to "Alternative Vorgehensweise über die Konsole" to make clear that this is just a different approach. |
Possibly mention that this procedure is also possible/useful for new Contao installations (in a info box maybe). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw. what about doing it via the Contao Manager locally?
Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
Why would I want to do this if I have the power of the command line ;-) Serious reason for not recommending this: The Contao Manager has enabled the resolver cloud by default. IMO this would generate a lot of unnecessary traffic for the Cloud Resolver (still people seem to do this as questions concerning the Manager where also XAMPP or MAMP are mentioned can be seen now and then). Additionally: what would be the benefit compared to using the Manager on the web hosting? |
Well this guide is targeted towards people who would usually use the Contao Manager and the Cloud Resolver, isn't it?
You need to disable that of course and mention that in the guide.
The benefit would be to resolve the dependencies locally, instead of using the Cloud Resolver. |
I see. Having never used the manager locally I‘ll try this myself first and then update the PR. Thanks for the feedback! |
Möglichkeit Neu Installation über den CM: Möglichkeit bei bestehender Installation über den CM: |
I am not sure if this is necessary when using the .lock with composer install via the CM? |
This is a guide on how to resolve the dependencies locally. |
You are absolutely right - Sorry ... |
As suggested by @fritzmg I added a section on using the contao manager locally. I additionally removed the section "Ausblick", as i rather see that as a new section in "Guides". As I'm not a manager user, could you please check if the descriptions make sense? Thanks! |
lgtm 👍 (disclaimer: I am not a CM user either). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Andreas.
}, | ||
"require": { | ||
... | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
``` | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@netzarbeiter I do not get, what that change is supposed to correct.
The suggested change removes the closing ```
and inroduces a }
. Do you want to add the }
as the closing brace of "require": {
block? The backticks to close the code block would still be required though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like the unclosed }
of the pseudo json code caused the error
Co-authored-by: netzarbeiter <netzarbeiter@users.noreply.github.com>
Co-authored-by: netzarbeiter <netzarbeiter@users.noreply.github.com>
Co-authored-by: netzarbeiter <netzarbeiter@users.noreply.github.com>
Co-authored-by: netzarbeiter <netzarbeiter@users.noreply.github.com>
Co-authored-by: netzarbeiter <netzarbeiter@users.noreply.github.com>
Co-authored-by: netzarbeiter <netzarbeiter@users.noreply.github.com>
Co-authored-by: netzarbeiter <netzarbeiter@users.noreply.github.com>
Co-authored-by: netzarbeiter <netzarbeiter@users.noreply.github.com>
adding a blank after the ` ```json` at least mademy editor's codehighlighting happy. Maybe it helps here too?
This is a first draft for the new section (see #575). Comments and suggestions are welcome. Especially regarding the section "Ausblick" where I'm not sure if that makes sense, as a developer should know how to do that and it might look "frightening" to the non technical user. My current opinion: do not include it—the example is only half of the job anyway.
An english translation will follow once we agree on the german version.