Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file contao-lokal-installieren.de.md #99

Merged
merged 35 commits into from
May 22, 2020
Merged

Add file contao-lokal-installieren.de.md #99

merged 35 commits into from
May 22, 2020

Conversation

fkaminski
Copy link
Contributor

Local installation example using docker devilbox project.

Installation with docker devilbox
Copy link
Contributor Author

@fkaminski fkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be more useful to deposit the descriptions in individual pages. Then later additional LAMP stacks can be added here.

Should i change that?

Copy link
Contributor Author

@fkaminski fkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have moved the Chapter "Lokale Installationen" to new subfolder ...

Copy link
Contributor

@xchs xchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed some typos.

docs/manual/installation/lokale-installation/_index.de.md Outdated Show resolved Hide resolved
docs/manual/installation/lokale-installation/_index.de.md Outdated Show resolved Hide resolved
docs/manual/installation/lokale-installation/_index.de.md Outdated Show resolved Hide resolved
docs/manual/installation/lokale-installation/_index.de.md Outdated Show resolved Hide resolved
docs/manual/installation/lokale-installation/_index.de.md Outdated Show resolved Hide resolved
Copy link
Contributor

@xchs xchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed some typos.

@fkaminski
Copy link
Contributor Author

Fixed some typos.

OK, do i have to change these now in my forke repo?

@fkaminski
Copy link
Contributor Author

@xchs - a PR workflow is very new for me - so:
I do not know what to do next. ...

@xchs
Copy link
Contributor

xchs commented Oct 18, 2019

@fkaminski The code changes can be committed by the users with write permissions to the repo.

@fkaminski
Copy link
Contributor Author

fkaminski commented Oct 18, 2019

@fkaminski The code changes can be committed by the users with write permissions to the repo.

Ok, thanks, with to the repo you mean this original one - right?. So nothing further to do for me.
Tried to understand this one: https://help.github.com/en/articles/committing-changes-to-a-pull-request-branch-created-from-a-fork.

I'll try to do better next time ...
Anyway - thank you for your suggestions and help

Thank you @xchs.
I hope I understood the procedure now.

Co-Authored-By: Hannes <github@gmx.net>
Copy link
Contributor

@fritzmg fritzmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The path and filename should be English. You should then translate the URL with the url front matter variable (including the language prefix, see #105).

I realize that currently the manual does not use English filenames, but I think we should. I will discuss this with @netzarbeiter next week.

@fkaminski
Copy link
Contributor Author

So in the future you woud like to see filenames for example like:
Instead of inhaltselemente.de.md

  • contentelements.de.md
  • contentelements.en.md
  • etc.

All with the url front matter variable including the correct language prefix then.

@fritzmg
Copy link
Contributor

fritzmg commented Oct 21, 2019

All with the url front matter variable including the correct language prefix then.

Just for the German version. The English version would already be correct.

Add url front matter variable with de language prefix
@fritzmg
Copy link
Contributor

fritzmg commented Oct 21, 2019

Btw. @netzarbeiter we should require English translations for new content as well, before merging, shouldn't we?

@xchs
Copy link
Contributor

xchs commented Oct 21, 2019

we should require English translations for new content as well, before merging, shouldn't we?

This would, of course, be a good thing in the first place, but this could be a too great hurdle for some people so they may not be contributing anything at all.

@fritzmg
Copy link
Contributor

fritzmg commented Oct 21, 2019

I know, they don't have to supply the translation themselves :). Once the German part is finished, I can provide the English translation for example. But I would directly add it to the PR. Or someone else can provide a PR for their PR.

@fkaminski
Copy link
Contributor Author

fkaminski commented Oct 21, 2019

What about to force the english version in terms of file structure with content like:

  • This content is not yet translated etc. and with a link back to the german file

This would reduce the hurdle to cooperate and still provide consistency ...

@fkaminski
Copy link
Contributor Author

According to #107 (comment)
Should i remove the language prefix again?

@fritzmg
Copy link
Contributor

fritzmg commented Oct 22, 2019

Yes please :)

@fkaminski
Copy link
Contributor Author

fkaminski commented Oct 22, 2019

Could someone translate this PR content to english please.

fkaminski and others added 3 commits October 22, 2019 17:28
Adds a comment that there are several ways to install contao locally ....
English translation
@fkaminski
Copy link
Contributor Author

Added PR #119 -
Maybe it's better to move this (local installation guides) to the new chapter "Guides".

docs/manual/guides/local/_index.en.md Outdated Show resolved Hide resolved
docs/manual/guides/local/_index.en.md Outdated Show resolved Hide resolved
docs/manual/guides/local/devilbox.en.md Outdated Show resolved Hide resolved
docs/manual/guides/local/devilbox.en.md Outdated Show resolved Hide resolved
docs/manual/guides/local/devilbox.en.md Outdated Show resolved Hide resolved
docs/manual/guides/local/devilbox.en.md Outdated Show resolved Hide resolved
docs/manual/guides/local/devilbox.en.md Outdated Show resolved Hide resolved
docs/manual/guides/local/devilbox.en.md Outdated Show resolved Hide resolved
docs/manual/guides/local/devilbox.en.md Outdated Show resolved Hide resolved
docs/manual/guides/local/devilbox.en.md Outdated Show resolved Hide resolved
Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
@netzarbeiter netzarbeiter self-requested a review as a code owner May 22, 2020 09:56
netzarbeiter and others added 16 commits May 22, 2020 11:56
Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
netzarbeiter and others added 4 commits May 22, 2020 12:00
Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
@netzarbeiter netzarbeiter merged commit 662f706 into contao:master May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants